Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the ability to retreive orderid and ability id from channelabilitypreset #30

Merged
merged 3 commits into from
Jan 7, 2018
Merged

add the ability to retreive orderid and ability id from channelabilitypreset #30

merged 3 commits into from
Jan 7, 2018

Conversation

IgorSamurovic
Copy link
Contributor

No description provided.

Frotty
Frotty reviewed Jan 7, 2018
View reviewed changes
wurst/objediting/presets/ChannelAbilityPreset.wurst Outdated
@@ -5,6 +5,8 @@ import public ObjectIds
import public ObjectIdGenerator
import OrderStringFactory
import BitSet
import HashMap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to map strings to ability ids, then I realized it's a bad idea xD

@Frotty Frotty merged commit 213c736 into wurstscript:master Jan 7, 2018
@Frotty
Copy link
Member

Frotty commented Jan 7, 2018

👍

@IgorSamurovic IgorSamurovic deleted the channelpresetorderstring branch January 7, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frotty Frotty Frotty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IgorSamurovic @Frotty